Implement missing functions for 2.6.x#236
Closed
Marioalexsan wants to merge 2 commits intoSFML:2.6.xfrom
Closed
Conversation
Marioalexsan
force-pushed
the
2.6.x
branch
2 times, most recently
from
2ca2a80 to
91583f8
Compare
ChrisThrasher
requested changes
Mar 6, 2024
ChrisThrasher
approved these changes
Mar 10, 2024
Member
ChrisThrasher
left a comment
ChrisThrasher
left a comment
There was a problem hiding this comment.
Barring an ultra-critical whitespace error I think this is good. Eager to see you fold this into SFML.Net to confirm it's all working!
Member
|
It appears that in trying to fix this whitespace error myself then squashing the new commit that was created, I accidentally pushed these changes straight to 2.6.x. I didn't realize your PR was opened from your own repo's 2.6.x branch. I'm used to that not being the case and thus I can edit the PR's branch without affecting the target branch. Oh well. I was already going to merge it anyways so the outcome is all the same. Thanks for your work! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured I might as well make an attempt at this. Not sure if
sfMallocis needed but I added it in for completeness.Fixes #235.